As described in the pull template: " Each component has a single commit (if 
not, squash them into one commit)" - so yes this is generally good.
It makes review easier, we also don't want to include your local development 
"history" in our master branch. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667
_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to