Thanks for the comments and questions.

Q: this is not a new algorithm, but an option to use with relative weights 
algorithm
A: This is correct, I think the documentation is accurate on this point, adding 
new one was not needed, let me know if you think this would be more clear ?

Q: I noticed a mutex (lock) was added per set -- it is required only in the 
context of using this new feature? Does it affect using relative weights 
without congestion control?
A: Correct, it is only needed with CC, because the SIP OPTIONS ping are 
processed by each worker and they can endup redistributing the weight 
simultaneously.
Do you think we should try make the lock optional (only enforced when 
absolutely needed) ?
My tought was that without CC it will be used very unfrequently when a GW times 
out.

A: the cc attribute needs to be set in all destination records belonging to the 
same set when wanting to use this new feature?
- correct this is more flexible I believe since you can activate congestion 
detection per gateway, if CC is not set the GW will always keeps its weight. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1533#issuecomment-394739107
_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to