@miconda: It is not strictly a bugfix - but as you said it brings coherence to 
the module with the other values for db_mode. So I have nothing against the 
exception to merge it now in the current phase of development. To addea module 
parameter is a good idea as well.

@adil-mafzool: I have one question about your patch: you create both a new 
urecord and a ucontact in the timer callback function, and I think both are 
allocated in new memory. But you only cleanup the ucontact, not the urecord 
after the callback processing. Is this not necessary or it is cleanup at 
another place?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1683#issuecomment-432540948
_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to