It is no regression as it was not working and it was expected to print what 
benchmark does when used in config file.

This features was added not to enclose each action in kamailio confg between a 
bm_start_time() and bm_log_time(), extended for db queries for better way to 
identify the slow operations.

So the actually expectation was to print micro-seconds as benchmakr does. 
Therefore multiplying with 1000 is not a proper fix here, it must stay 
microseconds in its base, with option to change if people want (or they 
expected) a different unit. That can be made default to miliseconds for old 
editions and let to microseconds for master branch. But I would go and ask in 
the community and see what most of them expected there as time unit.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1956#issuecomment-493590496
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to