@henningw I've made a review on my own, before asking a second opinion. The
patch remained open for more than 10 days, which I think is too much. I wasn't
aware that you are still reviewing the patch.
The whole mode is in "work in progress" state, so I am willing to accept
commented out code blocks in this state. It's more important to have proper
integration with the other IMS modules and working usecases for the IPSec
module itself.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2001#issuecomment-511529535
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev