There are several misunderstanding of the code

As I mentioned, I didn't find a function to do hash natively over an integer, 
so I used a string. I also asked, if there was any I could use, but received no 
answer. I guess std::hash is out of the question.

It's wrong to consider that hash will be done over "1", "2", "3", etc. Those 
are the indexes to the servers. I am not doing a hash over the indexes, but 
over the original hashes.

Also, my fault. maxRehash has a very misleading name. It was born as a "max", 
but then used as a counter. If Daniel could have read two lines above :

```                     
                                maxRehash--;
                        }
                        while (( maxRehash > 0 ) && 
ds_skip_dst(idx->dlist[fullHash % listSize].flags ) );

```
It's impossible to have there an infinite loop.

I don't like it as a new algorithm. And it has no sense to use it with other 
algorithms. It has sense only wth hash algorithms.

Forget the request. I withdraw it. I will use a patched version at my work.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2363#issuecomment-656224485
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to