The commit message first line has to start with the name of the module ("rr:
...") like per contributing guide:
*
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
It is important for generating changelogs and releases. I made a similar remark
to your latest commit as well.
Then, related to the commit itself, `myself` matching is related to routing
address (ip/domain) matching of the server, this should be the default
behaviour. Otherwise, on this case, it can happen that is matching headers
added by another node using same socket names, which can have unexpected side
effects in processing .
Personally I do not really see the need for what this patch brings, because you
can specify the domains associated with the sever on several ways: config alias
parameters, domain module (with register myself) for dynamic or large number of
domains and corex module for subdomains.
However, I am fine to add the behaviour of the patch, but controlled by a new
rr module parameter (e.g, myself_mode) , default being disabled (e.g.,
myself_mode=0) so the match is done like so far, on address elements only.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2643#issuecomment-782830125
_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
