Hi Carsten,

Maybe you could have a look to this code - it was added some time ago to the 
dialog module.
The msg parameter should probably be set, but it was creating compilation 
warnings, so it was removed. It was not able to guess the fix for that by 
looking at the code.

Thanks,

Henning

-- 
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com

-----Original Message-----
From: sr-dev <[email protected]> On Behalf Of Henning Westerholt
Sent: Wednesday, November 16, 2022 4:52 PM
To: [email protected]
Subject: [sr-dev] git:master:83b1ebb1: dialog: remove variable self-assignment 
that causes compilation warnings

Module: kamailio
Branch: master
Commit: 83b1ebb1ef7f6eb5a2fbc05f0da5a0e9a1109eca
URL: 
https://github.com/kamailio/kamailio/commit/83b1ebb1ef7f6eb5a2fbc05f0da5a0e9a1109eca

Author: Henning Westerholt <[email protected]>
Committer: Henning Westerholt <[email protected]>
Date: 2022-11-16T15:51:21Z

dialog: remove variable self-assignment that causes compilation warnings

---

Modified: src/modules/dialog/dlg_req_within.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/83b1ebb1ef7f6eb5a2fbc05f0da5a0e9a1109eca.diff
Patch: 
https://github.com/kamailio/kamailio/commit/83b1ebb1ef7f6eb5a2fbc05f0da5a0e9a1109eca.patch

---

diff --git a/src/modules/dialog/dlg_req_within.c 
b/src/modules/dialog/dlg_req_within.c
index c073988448..05305950b0 100644
--- a/src/modules/dialog/dlg_req_within.c
+++ b/src/modules/dialog/dlg_req_within.c
@@ -488,7 +488,6 @@ dlg_t * build_dlg_t_early(struct sip_msg *msg, struct 
dlg_cell * cell,
                                        branch_id, cell->t->nr_of_outgoings);
                        goto error;
                }
-               msg = msg;
        }
 
        if (!msg->contact && (parse_headers(msg,HDR_CONTACT_F,0)<0


_______________________________________________
Kamailio (SER) - Development Mailing List [email protected] 
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to