@miconda commented on this pull request.


> @@ -490,10 +503,9 @@ int tps_msg_received(sr_event_param_t *evp)
                        }
                }
                dialog = (get_to(&msg)->tag_value.len>0)?1:0;
-               if(dialog) {
-                       /* dialog request */
-                       tps_request_received(&msg, dialog);
-               }
+               
+               tps_request_received(&msg, dialog);
+               

The config has to process the SIP message as it would be without topos (or 
topoh), otherwise things become more complex to track (accounting, 
troubleshooting, sipdump, ...). Masking the call id comes with a prefix:

  - 
https://www.kamailio.org/docs/modules/stable/modules/topoh.html#topoh.p.callid_prefix

If the prefix is not matched, unmasking is not done, see th_unmask_callid() 
from topoh.

At the end, even it has to be more complexity added to topos module, it is the 
way to go, instead of affecting everything else.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3334#discussion_r1087520280
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3334/review/[email protected]>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to [email protected]

Reply via email to