Hi, this was actually triggered from the dlg_req_within() function, not from the dlg_bye() method. I use this to, for example, send in-dialog INFO/PRACK/UPDATE Messages, which should not cause the dialog to be terminated ;-)
Thanks, Carsten -- Carsten Bock I CTO & Founder ng-voice GmbH Trostbrücke 1 I 20457 Hamburg I Germany T +49 179 2021244 I www.ng-voice.com Registry Office at Local Court Hamburg, HRB 120189 Managing Directors: Dr. David Bachmann, Carsten Bock Am Do., 16. Feb. 2023 um 17:18 Uhr schrieb Henning Westerholt <[email protected] >: > Hi Carsten, > > I did not look into the code, but wondered why you do not want to execute > a BYE callback for an (in-dialog) BYE? > > Cheers, > > Henning > > -- > Henning Westerholt - https://skalatan.de/blog/ > Kamailio services - https://gilawa.com > > -----Original Message----- > From: Carsten Bock <[email protected]> > Sent: Thursday, February 16, 2023 4:28 PM > To: [email protected] > Subject: [sr-dev] git:master:ac0edd34: dialog: Do not trigger bye_reply_cb > for in-dialog requests > > Module: kamailio > Branch: master > Commit: ac0edd34b491dc78bca6979d2f1444c50bfb7399 > URL: > https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399 > > Author: Carsten Bock <[email protected]> > Committer: Carsten Bock <[email protected]> > Date: 2023-02-16T16:27:39+01:00 > > dialog: Do not trigger bye_reply_cb for in-dialog requests > > --- > > Modified: src/modules/dialog/dlg_req_within.c > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.diff > Patch: > https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.patch > > --- > > diff --git a/src/modules/dialog/dlg_req_within.c > b/src/modules/dialog/dlg_req_within.c > index 4f9ebfc693..a91bcec246 100644 > --- a/src/modules/dialog/dlg_req_within.c > +++ b/src/modules/dialog/dlg_req_within.c > @@ -697,7 +697,7 @@ int dlg_request_within(struct sip_msg *msg, struct > dlg_cell *dlg, int side, > > set_uac_req(&uac_r, method, allheaders.len?&allheaders:NULL, > (content && content->len)?content:NULL, > dialog_info, TMCB_LOCAL_COMPLETED, > - bye_reply_cb, (void*)iuid); > + NULL, NULL); > > result = d_tmb.t_request_within(&uac_r); > > > _______________________________________________ > Kamailio (SER) - Development Mailing List To unsubscribe send an email to > [email protected] >
_______________________________________________ Kamailio (SER) - Development Mailing List To unsubscribe send an email to [email protected]
