I did some reading of the code and looks like it does not affect current 
behavior nor have any performance impact if the the stats are off.

But if I understood correctly, in the PR, matching of a SIP request/reply to an 
lcr gw is done based on IP address/port (`fetch_gw_id` function).  On my LCR 
module web page, I have:
```
LCR Instance 'default' Gateway 'test'

Inbound Properties
Common Name or IP Address | Transport

Outbound Properties
IP Address or Domain Name | Port | Transport
```
That is, it is possible that LCR  module does not have any knowledge of the IP 
address/port of a gateway.

The only way I can find if a request comes from a gateway specified by Common 
Name is in the script like this:
```
        $var(gw_in_id) = $sht(htable=>cn::$tls_peer_subject_cn::gw_id);
```
That is, looking a common name match from htable.

So unless I didn't read the code correctly, I don't consider it a good idea to 
have a stats feature that applies only to some gateways.











-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3391#issuecomment-1465001446
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3391/[email protected]>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to [email protected]

Reply via email to