> On 19 Oct 2023, at 14:02, Chaigneau, Nicolas via sr-dev > <[email protected]> wrote: > > Hello Henning, > > > Here is a pull request for this : > > https://github.com/kamailio/kamailio/pull/3609 > > I’ve left some notes.
> Let me know if it’s ok. > If it can be merged, I would like to backport the changes to 5.7.x branch. > (should I also do a pull request for this branch ?) > We do not add new features to old branches. New features are part of new releases. Thank you for contributing to Kamailio! /O > > Regards, > Nicolas. > > De : Henning Westerholt <[email protected] <mailto:[email protected]>> > Envoyé : mardi 17 octobre 2023 19:23 > À : Kamailio (SER) - Development Mailing List > Cc : Chaigneau, Nicolas > Objet : RE: Kamailio module http_client - setting timeout in ms - new > parameter ? > > Hello Nicolas, > > sounds good, an additional parameter while keeping the existing functionality > for the existing timeout would work. > > Just create a pull request, then developers can review it and maybe some > smaller adjustments could be done before a merge. > > Thanks, > > Henning > > -- > Henning Westerholt – https://skalatan.de/blog/ > Kamailio services – https://gilawa.com <https://gilawa.com/> > > From: Chaigneau, Nicolas via sr-dev <[email protected] > <mailto:[email protected]>> > Sent: Dienstag, 17. Oktober 2023 18:11 > To: Kamailio (SER) - Development Mailing List <[email protected] > <mailto:[email protected]>> > Cc: Chaigneau, Nicolas <[email protected] > <mailto:[email protected]>> > Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new > parameter ? > > Hello, > > > I would like to set a timeout in milliseconds when using Kamailio module > http_client. > From what I read, the module is accepting a parameter “connection_timeout”: > > https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_client.p.connection_timeout > > This is used to set curl option “CURLOPT_TIMEOUT”. > I would like to set instead curl option “CURLOPT_TIMEOUT_MS”. > > I think changing the parameter “connection_timeout” from seconds to > milliseconds is not a good idea, since it would break existing configurations. > What about adding a new parameter “connection_timeout_ms” to the module ? > > Curl documentation says that: “If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS > are set, the value set last is used.” > The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so > that the current behaviour is kept if the new parameter is not configured. > > > What do you think ? > > > Regards, > Nicolas. > This message contains information that may be privileged or confidential and > is the property of the Capgemini Group. It is intended only for the person to > whom it is addressed. If you are not the intended recipient, you are not > authorized to read, print, retain, copy, disseminate, distribute, or use this > message or any part thereof. If you receive this message in error, please > notify the sender immediately and delete all copies of this message. > _______________________________________________ > Kamailio (SER) - Development Mailing List > To unsubscribe send an email to [email protected] > <mailto:[email protected]>
_______________________________________________ Kamailio (SER) - Development Mailing List To unsubscribe send an email to [email protected]
