@miconda commented on this pull request.
> @@ -910,7 +910,10 @@ int tps_request_received(sip_msg_t *msg, int dialog)
goto error;
}
metid = get_cseq(msg)->method_id;
- if((metid & (METHOD_BYE | METHOD_INFO | METHOD_PRACK | METHOD_UPDATE))
+ if(((metid & (METHOD_BYE | METHOD_INFO | METHOD_PRACK | METHOD_UPDATE))
+ || ((metid & (METHOD_NOTIFY))
+ && (msg->event
+ &&
strncmp(msg->event->body.s, "talk", 4) == 0)))
I would skip checking the event body to be "talk", there may be other event
types and I think it is not the proxy that should decide what events to be
accepted in such case.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3627#pullrequestreview-1710082892
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3627/review/1710082...@github.com>_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
