@herlesupreeth requested changes on this pull request.


>                               case AUTH_EV_RECV_ANS_SUCCESS:
                                        x->state = AUTH_ST_OPEN;
                                        update_auth_session_timers(x, msg);
-                                       //LM_INFO("state machine: i was in open 
and i am going to open\n");
+                                       //LM_INFO("state machine: I was in open 
and I am going to open\n");

I thin we can remove this commented code

>                                       break;
 
                                case AUTH_EV_RECV_ANS_UNSUCCESS:
                                        x->state = AUTH_ST_DISCON;
-                                       //LM_INFO("state machine: i was in open 
and i am going to discon\n");
+                                       //LM_INFO("state machine: I was in open 
and I am going to discon\n");

same as above. remove the commented code

>                                       break;
 
                                case AUTH_EV_SESSION_TIMEOUT:
                                case AUTH_EV_SERVICE_TERMINATED:
                                case AUTH_EV_SESSION_GRACE_TIMEOUT:
                                        x->state = AUTH_ST_DISCON;
-                                       //LM_INFO("state machine: i was in open 
and i am going to discon\n");
+                                       //LM_INFO("state machine: I was in open 
and I am going to discon\n");

same as above

>  
                                        Send_STR(s, msg);
                                        break;
 
                                case AUTH_EV_SEND_ASA_SUCCESS:
                                        x->state = AUTH_ST_DISCON;
-                                       //LM_INFO("state machine: i was in open 
and i am going to discon\n");
+                                       //LM_INFO("state machine: I was in open 
and I am going to discon\n");

same as above

>                                       Send_STR(s, msg);
                                        break;
 
                                case AUTH_EV_SEND_ASA_UNSUCCESS:
                                        x->state = AUTH_ST_OPEN;
                                        update_auth_session_timers(x, msg);
-                                       //LM_INFO("state machine: i was in open 
and i am going to open\n");
+                                       //LM_INFO("state machine: I was in open 
and I am going to open\n");

remove commented code

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3914#pullrequestreview-2176445533
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3914/review/[email protected]>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to [email protected]

Reply via email to