Module: kamailio
Branch: master
Commit: 31c77b2f81e23666fbd8d6d249d6b8ddce06483a
URL: 
https://github.com/kamailio/kamailio/commit/31c77b2f81e23666fbd8d6d249d6b8ddce06483a

Author: Daniel-Constantin Mierla <[email protected]>
Committer: Daniel-Constantin Mierla <[email protected]>
Date: 2024-08-27T12:38:25+02:00

core: propagate return code for forward uac helpers

---

Modified: src/core/forward.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/31c77b2f81e23666fbd8d6d249d6b8ddce06483a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/31c77b2f81e23666fbd8d6d249d6b8ddce06483a.patch

---

diff --git a/src/core/forward.c b/src/core/forward.c
index 97953ee7b85..ff73d957642 100644
--- a/src/core/forward.c
+++ b/src/core/forward.c
@@ -688,6 +688,9 @@ int forward_request_mode(struct sip_msg *msg, str *dst, 
unsigned short port,
 }
 
 
+/**
+ * forward request in stateless mode
+ */
 int forward_request(struct sip_msg *msg, str *dst, unsigned short port,
                struct dest_info *send_info)
 {
@@ -695,6 +698,9 @@ int forward_request(struct sip_msg *msg, str *dst, unsigned 
short port,
 }
 
 
+/**
+ * forward request like initial uac sender, with only one via
+ */
 int forward_request_uac(struct sip_msg *msg, str *dst, unsigned short port,
                struct dest_info *send_info)
 {
@@ -723,11 +729,8 @@ int forward_request_uac(struct sip_msg *msg, str *dst, 
unsigned short port,
        msg->msg_flags |= FL_VIA_NORECEIVED;
        ret = forward_request_mode(msg, dst, port, send_info, 
BUILD_NO_VIA1_UPDATE);
        msg->msg_flags = msg_flags_bk;
-       if(ret >= 0) {
-               return 1;
-       }
 
-       return -1;
+       return ret;
 }
 
 /**
@@ -787,11 +790,8 @@ int forward_uac_uri(sip_msg_t *msg, str *vuri)
        ret = forward_request_mode(
                        msg, &u->host, u->port_no, &dst, BUILD_NO_VIA1_UPDATE);
        msg->msg_flags = msg_flags_bk;
-       if(ret >= 0) {
-               return 1;
-       }
 
-       return -1;
+       return ret;
 }
 
 int update_sock_struct_from_via(

_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to [email protected]

Reply via email to