@henningw commented on this pull request.
> @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct
> minmax_mos_label_stats *mmls,
(char *)stream->child->iov[1].iov_base);
LM_DBG("rtpengine: XXX stream child val type %i\n",
stream->child->sibling->type);
- if((ssrc = bencode_dictionary_get_integer(stream,
"SSRC", -1))
- == -1)
- continue;
+ ssrc = bencode_dictionary_get_integer(stream, "SSRC",
-1);
+ if(ssrc == -1) {
+ ingress_ssrcs = bencode_dictionary_get_expect(
+ stream, "ingress SSRCs",
BENCODE_LIST);
+ if(!ingress_ssrcs || !ingress_ssrcs->child)
+ continue;
+ LM_DBG("rtpengine: XXX got ingress SSRCs\n");
I also noticed that. Generally we should try to have log messages that are
understandable and have some meaning. I don't get the meaning of this XXX in
this case. ;-)
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4233#discussion_r2078307257
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4233/review/2822905...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
