- Remove dep on crypto module
- Use core implementation
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #4353
#### Description
<!-- Describe your changes in detail -->
Replace module dependency by core implementation of sha1.
Test by placing a call between two clients.
Tests also were done with using `compute_sha1()` but not used in the PR to
produce the exact `hash_data` as before even though the output of it is
correct.
Hex printing probably differs due to non-terminated c strings?
Review is of course welcome.
``` c
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4573]:
select_rtpp_node_new(): Using SHA1 hash for callid
0342509280954d73a42f8311573dee99
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4581]:
select_rtpp_node_new(): SHA1 hash for callid 0342509280954d73a42f8311573dee99
is 2d0c1780 (as hex) old way
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4583]:
select_rtpp_node_new(): SHA1 hash for callid 0342509280954d73a42f8311573dee99
is *Ÿ#035eÊ#036@¤Û˜ûÄãº:‚'_Æ„ (as string) old way
---# Using `compute_sha_raw()`
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4589]:
select_rtpp_node_new(): SHA1_raw hash for callid
0342509280954d73a42f8311573dee99 is bd167410 (as hex) new way
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4595]:
select_rtpp_node_new(): SHA1_raw hash for callid
0342509280954d73a42f8311573dee99 is *Ÿ#035eÊ#036@¤Û˜ûÄãº:‚'_Æ„ (as string)
new way
```
Logs for usage of `compute_sha1()`.
``` c
# They produce correct sha1 as string
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4599]:
select_rtpp_node_new(): SHA1 hash for callid 0342509280954d73a42f8311573dee99
is bd167410 new way
Aug 13 13:31:01 app01 sbin/kamailio[3472802]: ERROR: {1 20855 INVITE
0342509280954d73a42f8311573dee99} rtpengine [rtpengine.c:4605]:
select_rtpp_node_new(): SHA1 hash for callid 0342509280954d73a42f8311573dee99
is 2a9f1d65ca1e40a4db98fbc4e3ba3a82275fc684 new way
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4366
-- Commit Summary --
* rtpengine: Replace sha1 generation
-- File Changes --
M src/modules/rtpengine/rtpengine.c (32)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4366.patch
https://github.com/kamailio/kamailio/pull/4366.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4366
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
