Hi all, While working on CMake backporting for 6.0, I came across this change: websocket: use core <https://github.com/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0> sha1<https://github.com/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0> instead of libssl for the handshake key<https://github.com/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0> [https://opengraph.githubassets.com/37dfe6d8f8cb945aadb8732524399cc50ca226a6e06bebc856995cc1b2fb2ad1/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0]<https://github.com/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0> websocket: use core sha1 instead of libssl for the handshake key · kamailio/kamailio@e0c0461<https://github.com/kamailio/kamailio/commit/e0c04615bb6a9f4a2077012481d4cbb5c669ecf0> - avoid the libssl crypto rwlock use github.com This depends on commit 2f0360888bcb0c576feffa944239007fac91936e<https://github.com/kamailio/kamailio/commit/2f0360888bcb0c576feffa944239007fac91936e>, which introduces SHA1 into the core.
My question is: should this SHA1 addition be treated as a new feature (and therefore not eligible for backport), or as a bug fix (since the websocket commit message states it “avoids the libssl crypto rwlock use”)? If we do consider it a fix, backporting it to 6.0 would also allow us to backport: * 22d7536f770bf03a7ede8a3dcd980bd3163c181d<https://github.com/kamailio/kamailio/commit/22d7536f770bf03a7ede8a3dcd980bd3163c181d> * acae32534942bd50436ec5e615193bd8f55f42cc<https://github.com/kamailio/kamailio/commit/acae32534942bd50436ec5e615193bd8f55f42cc> both of which are related to websocket CMake support (but not really important other than removing the deps and add the option). I know there were already some backports to 6.0 branch, just wanted to get a clarification on this. Please share any feedback within the next few days. Best regards, Xenofon
_______________________________________________ Kamailio - Development Mailing List -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!
