Ariana0699 left a comment (kamailio/kamailio#4328)
Hi @henningw,
Thanks for the thorough review! @daBatmanCoder and me have addressed all your
feedback in the latest force-push.
Some technical notes:
- The offset6/padded_len6 are intentionally absent, uint8 algo is a static type
in ABI encoding
- The switch statement in fixup_web3_auth() enables pseudo-variable support for
realm/method params
- curl per-call initialization is by design for thread safety and simplicity
We are looking forward to your review of the changes! And cf course, let us
know should you need any clarification on the adjustments we made.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4328#issuecomment-3425662375
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4328/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
