@henningw commented on this pull request.
Thanks for the PR. I have added a some comments about the change from my side.
> @@ -43,6 +43,12 @@
<affiliation><orgname>1&1 Internet
AG</orgname></affiliation>
<email>[email protected]</email>
</editor>
+ <editor>
For such small changes of a few lines we usually don't add Author assignments
to the readme. You are also not changing the README substancially, so I think
it should be removed, also the copyright statement below.
> @@ -17,12 +17,12 @@ CREATE TABLE `acc_cdrs` (
`id` INT(10) UNSIGNED AUTO_INCREMENT PRIMARY KEY NOT NULL,
`start_time` DATETIME DEFAULT '2000-01-01 00:00:00' NOT NULL,
`end_time` DATETIME DEFAULT '2000-01-01 00:00:00' NOT NULL,
- `duration` FLOAT(10,3) DEFAULT 0 NOT NULL
+ `duration` FLOAT(13,6) DEFAULT 0 NOT NULL
You also need to change the XML database source files in db/srdb1/schema/ Then
please re-generate the db schemas to see what is actually created from this
framework instead of manually changing the DB files.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4447#pullrequestreview-3382560409
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4447/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
