PV's may hold a string as well as an integer, and the s.int transformation
always assumes that an existing string value always represents the integer.
This is not the case for some PV's such as $rP where the string value is
not equal to the integer (ie, string "tls" and integer 3).
By ignoring the existing string value and always creating a new string from the
integer value, it is guaranteed that s.int always returns an numerical value.
Fixes #4444
N.B. I first tried removing the `PV_VAL_STR` flag and removing the int2str
altogether so conversion would be "on demand", but other code seem to
contain a bug and blindly use the string value even if `PV_VAL_STR` is not set.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #4444
#### Description
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4450
-- Commit Summary --
* pv: Always convert int to string in {s.int} transformation
-- File Changes --
M src/modules/pv/pv_trans.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4450.patch
https://github.com/kamailio/kamailio/pull/4450.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4450
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
