@herlesupreeth commented on this pull request.
> @@ -44,6 +44,34 @@ void contact_dlg_create_handler(
LM_DBG("Successfully registered contact dialog handler\n");
}
+
+/** removes the default port ':5060' from the string in order compare later
+ * returns:
+ * 0 => found
+ * 1 => not found
+ * < 0 => error
+ */
+static int filter_default_port(str *src, str *dst)
+{
+ str default_port = str_init(":5060");
not sure I understand the reason for filtering only default port? I mean why
not filter out the port part in general. Because there could another AoR
corresponding to IPSec port from which UE sent the second SIP REGISTER after 401
> *scontact = impucontact->contact;
return 0;
}
+ if(alias_term) {
+ LM_DBG("Comparing [%.*s] and [%.*s]\n",
alias_searchlen, s_term,
+ c_searchlen, c_term);
+ if(strncmp(c_term, s_term, alias_searchlen) ==
0) {
+ *scontact = impucontact->contact;
+ return 0;
+ }
+ }
+ }
+ if(impucontact->contact) {
didnt get this check .. at line 125 its the same check right?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4454#pullrequestreview-3389826214
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4454/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
