#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Use `db_redis_key_add_str()` where possible No sense to use `db_redis_key_add_string()`, if there is `str` object and not the char array. Add string key length protection Introduce a list of improvements for size overflow protection: - change func signatures to work with `size_t` only - check the raw pointer and its length This measure will protect inserts from extremely large key size (e.g. possible negative length that then gets into integer overflow). Add support of `max_key_length` Introduce the modparam `max_key_length` which, if used, controls the max possible key length to be used when adding/prepending strings into the redis key. By default disabled (means 0). If used will be always compared against the given string key length. This change provides full backwards compatibility. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4540 -- Commit Summary -- * db_redis: use `db_redis_key_add_str()` where possible * db_redis: add string key length protection * db_redis: add support of `max_key_length` -- File Changes -- M src/modules/db_redis/db_redis_mod.c (2) M src/modules/db_redis/doc/db_redis.xml (5) M src/modules/db_redis/doc/db_redis_admin.xml (19) M src/modules/db_redis/redis_dbase.c (7) M src/modules/db_redis/redis_table.c (31) M src/modules/db_redis/redis_table.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4540.patch https://github.com/kamailio/kamailio/pull/4540.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4540 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________ Kamailio - Development Mailing List -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!
