xkaraman left a comment (kamailio/kamailio#4544)

Hey @miconda,

We introduced the sha3 transformation and keccak but the interface is slightly 
different than the sha2 variant.

This PR uses a second parameter to determine the size like 
`$(var(x){s.sha3,bitSize}` where `bitSize=256|384|512` else it fails. Same for 
`keccak` variant with `$(var(x){s.keccak,512}`. One can also use it with no 
extra parameter like `$(var(x){s.sha3}` and will default to 256.

Would you prefet to have it like the sha2 interface with each one a different 
transformation like a `sha3-256` or something similar?

Not sure if order and size of `enum _tr_s_subtype` also matters, if you want me 
to add them to the end.

thanks



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4544#issuecomment-3719616842
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4544/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to