Module: kamailio
Branch: 5.8
Commit: 6dbc891ec89c21da5225f0181a7743ccf5cb3bda
URL: 
https://github.com/kamailio/kamailio/commit/6dbc891ec89c21da5225f0181a7743ccf5cb3bda

Author: Victor Seva <[email protected]>
Committer: Victor Seva <[email protected]>
Date: 2026-01-15T10:15:25+01:00

ims_registrar_scscf: fix missing unlocks at update_contacts()

issue introduced at 75904895577d0329ba0d30d10e645b8769451e51

fix #4553

(cherry picked from commit dacfbbf4d919c3004827bc7a0107c37a9bf77655)
(cherry picked from commit 8529975a9e2fc9f61dcde50955db02c78c7157b4)

---

Modified: src/modules/ims_registrar_scscf/save.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/6dbc891ec89c21da5225f0181a7743ccf5cb3bda.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6dbc891ec89c21da5225f0181a7743ccf5cb3bda.patch

---

diff --git a/src/modules/ims_registrar_scscf/save.c 
b/src/modules/ims_registrar_scscf/save.c
index d795328704b..b6132038930 100644
--- a/src/modules/ims_registrar_scscf/save.c
+++ b/src/modules/ims_registrar_scscf/save.c
@@ -952,6 +952,7 @@ int update_contacts(struct sip_msg *msg, udomain_t *_d, str 
*public_identity,
                                                                != 0) {
                                                        LM_DBG("Contact does 
not exist <%.*s>\n",
                                                                        
chi->uri.len, chi->uri.s);
+                                                       ul.unlock_udomain(_d, 
&pi->public_identity);
                                                        goto error;
                                                }
                                                event_reg(0, impu_rec, ucontact,
@@ -1089,6 +1090,7 @@ int update_contacts(struct sip_msg *msg, udomain_t *_d, 
str *public_identity,
                                                                != 0) {
                                                        LM_DBG("Contact does 
not exist <%.*s>\n",
                                                                        
chi->uri.len, chi->uri.s);
+                                                       ul.unlock_udomain(_d, 
&pi->public_identity);
                                                        goto error;
                                                }
                                                event_reg(0, impu_rec, ucontact,
@@ -1227,6 +1229,8 @@ int update_contacts(struct sip_msg *msg, udomain_t *_d, 
str *public_identity,
                                                                                
LM_DBG("Contact does not exist "
                                                                                
           "<%.*s>\n",
                                                                                
                chi->uri.len, chi->uri.s);
+                                                                               
ul.unlock_udomain(
+                                                                               
                _d, &pi->public_identity);
                                                                                
goto error;
                                                                        }
                                                                        
notify_subscribers(tmp_impu_rec, ucontact,

_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to