#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description ##### Problem The default timestamp format (integer milliseconds) in xhttp_prom metrics violates the OpenMetrics specification, which requires timestamps in seconds. Monitoring systems like Grafana Alloy and Mimir reject millisecond timestamps, causing metrics ingestion failures. ##### Solution Added new module parameter `timestamp_format` with three configuration options: - **"ms"** (default): Integer milliseconds - maintains backward compatibility - **"s"**: Integer seconds - OpenMetrics compliant - **"sf"**: Seconds with fractional milliseconds - OpenMetrics compliant with sub-second precision ##### Testing - Default behavior tested (parameter omitted defaults to "ms") - All three timestamp formats validated with regex pattern matching - Backward compatibility confirmed - Module compiles cleanly with no warnings ##### Related Files - Module documentation updated in `doc/xhttp_prom_admin.xml` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4557 -- Commit Summary -- * xhttp_prom: add timestamp_format parameter -- File Changes -- M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (70) M src/modules/xhttp_prom/prom.c (118) M src/modules/xhttp_prom/prom.h (9) M src/modules/xhttp_prom/prom_metric.c (42) M src/modules/xhttp_prom/xhttp_prom.c (61) M src/modules/xhttp_prom/xhttp_prom.h (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4557.patch https://github.com/kamailio/kamailio/pull/4557.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4557 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________ Kamailio - Development Mailing List -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!
