@miconda commented on this pull request.


> @@ -260,6 +263,14 @@ static int mod_init(void)
                        return -1;
                }
        }
+       if(_tps_methods_update_time_list.len > 0) {
+               if(parse_methods(
+                                  &_tps_methods_update_time_list, 
&_tps_methods_update_time)
+                               < 0) {
+                       LM_ERR("failed to parse methods_update_time 
parameter\n");
+                       return -1;
+               }
+       }

I would consider to check if len <= 0, then `_tps_methods_update_time = 0`. The 
string parameter is defaulting to `SUBSCRIBE`, so by parsing it in mod init 
because the len > 0, the default is to update on SUBSCRIBEs like so far.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4561#discussion_r2720753472
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4561/review/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to