If no shm available when at dmq_ul.insert_urecord(), will cause a crash when
trying to dmq_ul.insert_ucontact().
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Fix below crash that happened when kamailio was running low on SHM:
```
(gdb) bt
#0 0x00007f376e38d4ae in mem_insert_ucontact (_r=_r@entry=0x0,
_c=0x7ffda8d73f00, _ci=0x7f376e0b5440 <ci>) at urecord.c:148
#1 0x00007f376e38fdcf in insert_ucontact (_r=0x0, _contact=<optimized
out>, _ci=<optimized out>, _c=0x7ffda8d73ed8) at urecord.c:588
#2 0x00007f376e0a823d in add_contact (ci=0x7f376e0b5440 <ci>, aor=...)
at usrloc_sync.c:130
#3 usrloc_dmq_execute_action (jdoc_action=<optimized out>,
node=node@entry=0x7f3771b79cf0) at usrloc_sync.c:474
#4 0x00007f376e0ad52b in usrloc_dmq_handle_msg (msg=<optimized out>,
resp=0x7ffda8d74120, node=0x7f3771b79cf0) at usrloc_sync.c:579
#5 0x00007f376e0dca94 in worker_loop (id=id@entry=0) at worker.c:80
#6 0x00007f376e0baa21 in child_init (rank=<optimized out>) at dmq.c:329
#7 0x0000563bdae3acba in init_mod_child (m=0x7f37eefb4d70, rank=rank@entry=0)
at core/sr_module.c:919
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4593
-- Commit Summary --
* dmq_usrloc: improve return codes checking on add contact
-- File Changes --
M src/modules/dmq_usrloc/usrloc_sync.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4593.patch
https://github.com/kamailio/kamailio/pull/4593.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4593
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
