@miconda commented on this pull request.
> @@ -89,6 +89,7 @@ int dlgs_destroy(void)
int dlgs_sipfields_get(sip_msg_t *msg, dlgs_sipfields_t *sf)
{
memset(sf, 0, sizeof(dlgs_sipfields_t));
+ via_body_t *via1 = msg->h_via1 ? (msg->h_via1)->parsed : NULL;
Variables should be declared at the beginning of functions or blocks.
> @@ -423,6 +463,7 @@ dlgs_item_t *dlgs_get_item(sip_msg_t *msg)
while(it != NULL && it->hashid == hid) {
if(cid->len == it->callid.len
&& strncmp(cid->s, it->callid.s, cid->len) ==
0) {
+ /* Don't check branch-id, spiraling or parallel forking
not supported */
The comment is confusing, I guess that if an item is added because it has same
call-id, but different Via branch, it is because of serial/parallel forking. Or
is it added if a previous dlgs item is marked as terminated due to a >=300 code
of a prior serial step?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4595#pullrequestreview-3865584862
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4595/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
