<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR add two validation tests related to VIA.
1. Check if VIA is present through the `required_headers` function. the docs
suggest to check for it but code does not (not in this function anyway)
(considered a bug?)
Another note though is that sanity module may be not really acting on this at
all due to some sanity check found in
(https://github.com/kamailio/kamailio/blob/41c30c244ca0ca8b3c201e0c02602b2554f57cb3/src/core/receive.c#L448-L463)
and that kamailio cfg will drop the msg much earlier
2. Check if branch paramater is present in the Via header which is mandatory
according to RFC. (new feature)
Also increase a dbg to err log and check for host len more stricly. 0-len host
is not valid.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4643
-- Commit Summary --
* sanity: Add Via header to required_headers check
* sanity: Add branch sanity check for Via header
* sanity: Increase log to error
* sanity: Check host len more strictly
-- File Changes --
M src/modules/sanity/sanity.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4643.patch
https://github.com/kamailio/kamailio/pull/4643.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4643
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
