gaaf left a comment (kamailio/kamailio#4644)
Please don't keep unreachable code, tm's code is already hard enough to grasp.
Is it really safe/wanted to omit **all** the extra checks from path 3 and now
call `kill_transaction()` instead of just `t_release_transaction()` in those
cases? If so, please explain why in the commit message and remove the dead
code. Note that this code is 16+ years old, maybe the real cause is somewhere
else?
Maybe 2812bd9c426d was wrong and the extra condition had to be handled in path
1? Like so: `if (unlikely(kr == REQ_ERR_DELAYED || (kr == (REQ_ERR_DELAYED |
REQ_FWDED)))`
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4644#issuecomment-4067870492
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4644/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
