<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] Code is formatted with `clang-format` using the config file
`.clang-format`
from source code folder
- [ ] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
## Summary
Fix explicit expire handling in `ht_set_cell_ex()` when an existing entry is
replaced with a newly allocated cell.
## Problem
For explicit-expire updates, the replacement branches updated `it->expire`
instead of `cell->expire`. In these branches, `it` is the old entry and is
freed after relinking, so the new cell could keep `expire == 0`.
User-visible symptom:
- `htable.get` reports `expire` as `NEVER` after updating an existing key with
a longer string value via `htable.setxs`
## Reproducer
```
htable.sets c active_node_ip bla
htable.setxs c active_node_ip __disabled__ 100
htable.get c active_node_ip
```
Before the fix, expire could be reported as NEVER.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4745
-- Commit Summary --
* htable: fix expire value assignment on string cell replacements
-- File Changes --
M src/modules/htable/ht_api.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4745.patchhttps://github.com/kamailio/kamailio/pull/4745.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4745
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
