henningw left a comment (kamailio/kamailio#4754)

> > Thanks. Could you please check your PR, as there is a strange commit 
> > included 
> > ([5e28857](https://github.com/kamailio/kamailio/commit/5e2885732e1f720a509613db18a73d75ab770323)).
> >  This seems to contain a lot of other changes. Its probably not needed and 
> > should be removed.
> 
> Hi @henningw,
> 
> The last commit is only a merge with master, i didn't push any new change, 
> other than the new function.

Yes, can you please remove it? Please don't include merge commits in PRs, do a 
git rebase instead. The merge commit don't belong to the PR in the end.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4754#issuecomment-4632709304
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4754/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to