xkaraman left a comment (kamailio/kamailio#4759)
> ..this part of that line seems bogus (the single quotes):
> `xhttp_pi/''`
Yeah i see your point, but actually that's handled just fine and traversed
fine. path is expanded just fine to `xhttp_pi/` and doing the command manually
with various variations like `xhttp_pi/""` or `xhttp_pi/` work as expected and
copies to correct location. I don't like it either but couln't find an easy way
to tell cmake that some `dbs` need the `kamailio` sub-folder and some other are
not (var defaults to `''`, hence what you are seeing)
> Really seems like just a standard race condition to me, when running on many
> cpus.
I know, it looks like it, and i am not saying it isn't. I just tried on
multiple docker images like `rhel8`, `ubuntu`, `rocky-10`, with `-j8` and i
didn't replicate it, so i am trying to remove any other possibilities.
> dbschema_pi_framework_mod must wait for dbschema_pi_framework_table to finish.
This is not true, the files are generated independently and can be generated in
the same time (they produce different files also). they are produced though in
the same folder which is `build_folder/utils/kamctl/xhttp_pi/` as you said.
Each of these are a target by their own, and they have the `custom_command(...
POST_BUILD)` to copy the result files.
This is the only place i can see the race come into place, when one of the
target has completed and tries to copy the whole folder but the other target
still produces it's own files. Then copying the files that already exist, even
some of the other target is fine. it might some files are still being written
and can't be accessed there maybe? i guess so.
i ll try to isolate this and if not, the PR looks good, it won't mess anything
else i think, since it just adds a dependency to build each relevant target
sequentially.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4759#issuecomment-4689956738
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4759/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
