henningw left a comment (kamailio/kamailio#4786)
Thanks for the PR. I only had a brief look to the code so far. Several things
should be addressed:
- please format the code with clang-format, the specific check is failing, then
do a force-push to this PR
- a cmake file needs to be added as well, as we switched to this build system
some time ago
- you are using system malloc in several places, this should be replaced by the
Kamailio pgk_malloc/free variants unless its especially needed (e.g. for
interaction with external libraries)
- several global structs (e.g. hash_entry, config_type, template_type) should
be prefixed, e.g. rdn_hash_struct or similar
- Small utility functions in ims_rdn.c (e.g. key_exists) should be made static
- Review also the utility functions in rdn_trans.{h,c}, many of them should be
probably also made static
- There are some German log/debug and also comments messages that should be
translated to English
Regarding the note from @christoph-v-kontron, there seems to be
pseudo-variables exported, which is fine and actually the preferred way since
some time. But please also review of course.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4786#issuecomment-4776928782
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4786/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
