#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] LLM/AI Coding Assistants were involved in creating the C code or other included content - [x] Code is formatted with `clang-format` using the config file `.clang-format` from source code folder - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4799 #### Description A locally generated transaction can have uas.request==NULL when the outgoing buffer cannot be parsed back into a synthetic SIP message. On FR timeout with another DNS destination available, the failover path dereferenced the missing request and could crash the tm timer process. Disable DNS failover for such transactions when t_uac_prepare() cannot build the synthetic request. Also decline DNS failover when add_uac_dns_fallback() receives no originating request, and keep defensive NULL checks in the lower-level UAC builders. Fixes GH https://github.com/kamailio/kamailio/issues/4799. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4803 -- Commit Summary -- * tm: skip dns failover for msg-less local UAC -- File Changes -- M src/modules/tm/t_fwd.c (28) M src/modules/tm/uac.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4803.patch https://github.com/kamailio/kamailio/pull/4803.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4803 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/[email protected]>
_______________________________________________ Kamailio - Development Mailing List -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!
