Thanks for accepting the patch. No, i don't think any change in documentation is needed.
Thank you. On Tue, Oct 22, 2013 at 11:47 AM, Peter Dunkley < [email protected]> wrote: > Hello, > > I have committed the patch. Are there any updates that need to be made to > the module documentation? > > Regards, > > Peter > > > On 22 October 2013 03:34, Muhammad Shahzad <[email protected]> wrote: > >> I did a fresh install of debian 7.1 and centos 6.4 minimal. Then compiled >> latest stable kamailio from git, including mi_xmlrpc, xmlrpc and db_mysql >> modules. I observed bunch of warnings and missing declarations, which i >> have fixed in attached patch. >> >> Debian 7.1: >> debian:/usr/src/svn-src/kamailio/modules/mi_xmlrpc# xmlrpc-c-config >> --version >> 1.16.33 >> >> debian:/usr/src/svn-src/kamailio/modules/mi_xmlrpc# make clean >> debian:/usr/src/svn-src/kamailio/modules/mi_xmlrpc# make all >> CC (gcc) [M mi_xmlrpc.so] abyss_conf.o >> CC (gcc) [M mi_xmlrpc.so] abyss_conn.o >> CC (gcc) [M mi_xmlrpc.so] abyss_data.o >> CC (gcc) [M mi_xmlrpc.so] abyss_date.o >> CC (gcc) [M mi_xmlrpc.so] abyss_file.o >> CC (gcc) [M mi_xmlrpc.so] abyss_http.o >> CC (gcc) [M mi_xmlrpc.so] abyss_response.o >> CC (gcc) [M mi_xmlrpc.so] abyss_server.o >> CC (gcc) [M mi_xmlrpc.so] abyss_session.o >> CC (gcc) [M mi_xmlrpc.so] abyss_socket.o >> CC (gcc) [M mi_xmlrpc.so] abyss_socket_unix.o >> CC (gcc) [M mi_xmlrpc.so] abyss_thread_fork.o >> CC (gcc) [M mi_xmlrpc.so] abyss_token.o >> CC (gcc) [M mi_xmlrpc.so] abyss_trace.o >> CC (gcc) [M mi_xmlrpc.so] abyss_xmlrpc_server.o >> CC (gcc) [M mi_xmlrpc.so] mi_xmlrpc.o >> CC (gcc) [M mi_xmlrpc.so] xr_parser.o >> CC (gcc) [M mi_xmlrpc.so] xr_server.o >> CC (gcc) [M mi_xmlrpc.so] xr_writer.o >> make[1]: `libkmi.so.1.0' is up to date. >> LD (gcc) [M mi_xmlrpc.so] mi_xmlrpc.so >> >> >> CentOS 6.4: >> [root@localhost svn-src]# xmlrpc-c-config --version >> 1.16.24 >> >> [root@localhost mi_xmlrpc]# make clean >> [root@localhost mi_xmlrpc]# make all >> CC (gcc) [M mi_xmlrpc.so] abyss_conf.o >> CC (gcc) [M mi_xmlrpc.so] abyss_conn.o >> CC (gcc) [M mi_xmlrpc.so] abyss_data.o >> CC (gcc) [M mi_xmlrpc.so] abyss_date.o >> CC (gcc) [M mi_xmlrpc.so] abyss_file.o >> CC (gcc) [M mi_xmlrpc.so] abyss_http.o >> CC (gcc) [M mi_xmlrpc.so] abyss_response.o >> CC (gcc) [M mi_xmlrpc.so] abyss_server.o >> CC (gcc) [M mi_xmlrpc.so] abyss_session.o >> CC (gcc) [M mi_xmlrpc.so] abyss_socket.o >> CC (gcc) [M mi_xmlrpc.so] abyss_socket_unix.o >> CC (gcc) [M mi_xmlrpc.so] abyss_thread_fork.o >> CC (gcc) [M mi_xmlrpc.so] abyss_token.o >> CC (gcc) [M mi_xmlrpc.so] abyss_trace.o >> CC (gcc) [M mi_xmlrpc.so] abyss_xmlrpc_server.o >> CC (gcc) [M mi_xmlrpc.so] mi_xmlrpc.o >> CC (gcc) [M mi_xmlrpc.so] xr_parser.o >> CC (gcc) [M mi_xmlrpc.so] xr_server.o >> CC (gcc) [M mi_xmlrpc.so] xr_writer.o >> make[1]: `libkmi.so.1.0' is up to date. >> LD (gcc) [M mi_xmlrpc.so] mi_xmlrpc.so >> >> >> I will try out OpenSuse 12.3 and Fedora 19 later today and see if they >> are OK too with it. If there are any other distros i should test patch >> with, do let me know. >> >> Thank you. >> >> >> >> >> On Mon, Oct 21, 2013 at 6:36 PM, Muhammad Shahzad >> <[email protected]>wrote: >> >>> No, the patch does not update docs or Makefile. It just adds some ifdef >>> to couple of header files which enables / disables or fixes the missing >>> data structures. I am attaching patch here again for your reference. >>> >>> The version xmlrpc-c installed my production is 1.35.99 which is i guess >>> is git version. >>> >>> ms11:/usr/src/svn-src# xmlrpc-c-config --version >>> 1.35.99 >>> >>> However, i did test it with wheezy default xmlrpc-c version 1.16.33 on >>> my test machine. Both of these are working with Kamailio v4.0.1 (by manual >>> patching using attached file) and v4.0.4 (patch already included in git >>> source). >>> >>> ms11:/usr/src/svn-src# kamailio -version >>> version: kamailio 4.0.4 (i386/linux) cabe58 >>> flags: STATS: Off, USE_IPV6, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, >>> DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, >>> USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, >>> USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES >>> ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, >>> MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 4MB >>> poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. >>> id: cabe58 >>> compiled on 04:24:52 Oct 15 2013 with gcc 4.7.2 >>> >>> >>> ms11:/usr/src/svn-src# vim /usr/local/etc/kamailio/kamailio.cfg >>> ... >>> loadmodule "mi_xmlrpc.so" >>> ... >>> # ----- mi_xmlrpc params ----- >>> modparam("mi_xmlrpc", "port", 8880) >>> modparam("mi_xmlrpc", "log_file", "/var/log/abyss.log") >>> ... >>> >>> >>> ms11:/usr/src/svn-src# netstat -pln >>> ... >>> tcp 0 0 0.0.0.0:8880 0.0.0.0:* >>> LISTEN 19149/kamailio >>> ... >>> >>> >>> I haven't tested it on CentOS yet, I will check that tonight. >>> >>> Thank you. >>> >>> >>> >>> >>> On Mon, Oct 21, 2013 at 6:10 PM, Peter Dunkley < >>> [email protected]> wrote: >>> >>>> Hello, >>>> >>>> Did your patch update the module documentation too? >>>> What about the module Makefile? >>>> >>>> The module documentation for the devel branch states: >>>> >>>> libxmlrpc-c3-dev version 0.9.10 or version 1.06.[10-30]. >>>> >>>> The module Makefile checks for these same versions and the build >>>> process is very noisy if you don't have one of these versions. >>>> >>>> CentOS 6 (and CentOS 5) come with xmlrpc-c 1.16.24 and the latest >>>> version from SourceForge is 1.25.26. The versions from the documentation >>>> are very old: >>>> >>>> - 0.9.10 is from 2001 >>>> - 1.06.10 is from 2007 >>>> - 1.06.30 is from 2008 >>>> >>>> I can't believe that the latest Debian is using versions of xmlpc-c >>>> that are five years or more old. Incidently, the module in Git master >>>> won't build on CentOS at all. >>>> >>>> Regards, >>>> >>>> Peter >>>> >>>> >>>> >>>> On 21 October 2013 16:39, Muhammad Shahzad <[email protected]>wrote: >>>> >>>>> I send a patch last month which was i think has been merged to trunk >>>>> and latest stable 4.0. This patch makes it compatible with newer versions >>>>> of xmlrpc-c library. I tested myself with Debian 7.1 (wheezy). >>>>> >>>>> And yes this patch is useful in a number of ways. For example I have >>>>> been using it with openxcap to have xcap service running on different >>>>> machine then sip service. I also have a few monitoring applications using >>>>> mi_xmlrpc. Therefore, i would request to continue this module. I would be >>>>> happy to provide any patches needed to keep it up to date with kamailio >>>>> core and newer Linux distros. >>>>> >>>>> Thank you. >>>>> >>>>> >>>>> >>>>> >>>>> On Mon, Oct 21, 2013 at 3:02 PM, Peter Dunkley < >>>>> [email protected]> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> I was just looking at the dependencies for this and it requires a >>>>>> specific (and very old) version of xmlrpc-c to run. Even CentOS (both 5 >>>>>> and 6) contain much newer versions of xmlrpc-c. >>>>>> >>>>>> This leads me to suspect that no-one is using it on up-to-date >>>>>> systems, and if it is believed not to work with the versions of xmlrpc-c >>>>>> shipping today should it still be supported in Kamailio 4.1.0? >>>>>> >>>>>> Regards, >>>>>> >>>>>> peter >>>>>> >>>>>> >>>>>> -- >>>>>> Peter Dunkley >>>>>> Technical Director >>>>>> Crocodile RCS Ltd >>>>>> >>>>>> _______________________________________________ >>>>>> sr-dev mailing list >>>>>> [email protected] >>>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Mit freundlichen Grüßen >>>>> Muhammad Shahzad >>>>> ----------------------------------- >>>>> CISCO Rich Media Communication Specialist (CRMCS) >>>>> CISCO Certified Network Associate (CCNA) >>>>> Cell: +49 176 99 83 10 85 >>>>> MSN: [email protected] >>>>> Email: [email protected] >>>>> >>>>> _______________________________________________ >>>>> sr-dev mailing list >>>>> [email protected] >>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Peter Dunkley >>>> Technical Director >>>> Crocodile RCS Ltd >>>> >>>> _______________________________________________ >>>> sr-dev mailing list >>>> [email protected] >>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >>>> >>>> >>> >>> >>> -- >>> Mit freundlichen Grüßen >>> Muhammad Shahzad >>> ----------------------------------- >>> CISCO Rich Media Communication Specialist (CRMCS) >>> CISCO Certified Network Associate (CCNA) >>> Cell: +49 176 99 83 10 85 >>> MSN: [email protected] >>> Email: [email protected] >>> >> >> >> >> -- >> Mit freundlichen Grüßen >> Muhammad Shahzad >> ----------------------------------- >> CISCO Rich Media Communication Specialist (CRMCS) >> CISCO Certified Network Associate (CCNA) >> Cell: +49 176 99 83 10 85 >> MSN: [email protected] >> Email: [email protected] >> >> _______________________________________________ >> sr-dev mailing list >> [email protected] >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >> >> > > > -- > Peter Dunkley > Technical Director > Crocodile RCS Ltd > > _______________________________________________ > sr-dev mailing list > [email protected] > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > > -- Mit freundlichen Grüßen Muhammad Shahzad ----------------------------------- CISCO Rich Media Communication Specialist (CRMCS) CISCO Certified Network Associate (CCNA) Cell: +49 176 99 83 10 85 MSN: [email protected] Email: [email protected]
_______________________________________________ sr-dev mailing list [email protected] http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
