Hello,

should be fine to merge in master branch. Can you list the characters which are no longer escaped to be sure we don't introduce any issues to what people would expect based on old version?

Cheers,
Daniel

On 11/6/13 4:33 PM, Camille Oudot wrote:
Hi,

I've noticed that {s.escape.param} doesn't change "@" into "%40", and
yet RFC3261 specifies pvalue as

pvalue            =  1*paramchar
paramchar         =  param-unreserved / unreserved / escaped
param-unreserved  =  "[" / "]" / "/" / ":" / "&" / "+" / "$"

with:
       unreserved  =  alphanum / mark
       mark        =  "-" / "_" / "." / "!" / "~" / "*" / "'"
                      / "(" / ")"
       escaped     =  "%" HEXDIG HEXDIG

I've committed a patch in coudot/escape-param branch to fix the escape
function. Several unreserved characters were escaped, and some reserved
ones weren't.

Regards

--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda


_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to