Hello,

what is the state with this patch?

This tracker item seems related:

- http://sip-router.org/tracker/index.php?do=details&task_id=353&project=1

Cheers,
Daniel

On 16/11/13 20:36, Marius Zbihlei wrote:
Hello Lucian,

Sorry for the delay I was fairly busy and also I wanted to try to use Rietveld(*) for doing the code review(@Daniel ever think about extending something like this to all commits or all patches coming from contributors?)

So, I will do my review here:

https://codereview.appspot.com/27270044/ (@Lucian see the comments section for needed improvement)

(*) developed by Guido Van Rossum when working at Google. FOSS, but requires AppEngine



On Fri, Nov 8, 2013 at 4:37 PM, Lucian Balaceanu <[email protected] <mailto:[email protected]>> wrote:

    Hello Marius,

    I have attached a patched version of an internal parser for
    carrierroute. I would very much appreciate suggestions related to it.
    Some build dependencies would still have to be removed: fedora,
    openbsd and centos.

    Thank you,
    Lucian Balaceanu




    On 10/21/2013 11:04 AM, Marius Zbihlei wrote:
    That would be great! Thanks!
    Marius.


    On Mon, Oct 21, 2013 at 8:04 AM, Lucian Balaceanu
    <[email protected] <mailto:[email protected]>> wrote:

        Hi Marius,

        I will commit such a patch related to libconfuse. Maybe you
        want to have a look over it?

        Thank you,
        Lucian Balaceanu



        On 10/20/2013 11:51 PM, Marius Zbihlei wrote:
        Hi all,

        This has been in the back of my head from some time now.
        Libconfuse is a small project not distributed with major
        distros and unmaintained for 3.5 years now. As it is only
        used for reading of a simple cfg file, I want to write a
        simple parser that does the job(I do not want external deps
        ... see below why)

        Benefits: we can now pack carrierroute with the common used
        modules (as it will not have any external dependencies) and
        also will remove a lot of problems seen on the list
        regarding linkage of libconfuse.

        Any thoughts?

        Marius


        _______________________________________________
        sr-dev mailing list
        [email protected]  <mailto:[email protected]>
        http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


        _______________________________________________
        sr-dev mailing list
        [email protected] <mailto:[email protected]>
        http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev



    _______________________________________________
    sr-dev mailing list
    [email protected]  <mailto:[email protected]>
    http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev




_______________________________________________
sr-dev mailing list
[email protected]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

_______________________________________________
sr-dev mailing list
[email protected]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to