For the records, the commit was just backported to branch 5.1. Cheers, Daniel
On 28.11.18 17:29, Daniel-Constantin Mierla wrote: > Hello, > > what I actually said it was that if you backport to your local git clone > and testing was ok, then you can push it to 5.1 branch by yourself, no > need to wait for me or others to push it. But I can also do it tomorrow. > > Cheers, > Daniel > > On 28.11.18 15:10, Andreas Granig wrote: >> Hi Daniel, >> >> This commit indeed fixed the issue, thanks for pointing it out! From my >> point of view, it’s fine backporting it to 5.1 to fix it there as well. >> >> Best, >> Andreas >> >>> On 28.11.2018, at 13:45, Daniel-Constantin Mierla <[email protected]> wrote: >>> >>> Hello, >>> >>> ohh, I was looking at master and the commit I did seemed to be for the >>> place without a guard on dialog event type. >>> >>> The master branch has the one you point to already guarded, done with: >>> >>> - >>> https://github.com/kamailio/kamailio/commit/6d0f8994611b50faa7ef7d1299acf0c390a2eed1 >>> - https://github.com/kamailio/kamailio/pull/1453 >>> >>> So apparently it was overlooked when backporting to release versions of >>> 5.1.x. >>> >>> Can you cherry pick that commit and test? If all ok, you can push the >>> backport to 5.1 branch. The master and 5.2 should be fine. >>> >>> Cheers, >>> Daniel >>> >>> On 28.11.18 13:36, Andreas Granig wrote: >>>> Hi Daniel, >>>> >>>> Unfortunately that doesn’t help. Digging a bit further, it seems that the >>>> error comes from calling check_if_dialog() around line 715 in >>>> update_presentity(), so actually before entering the >>>> delete_presentity_if_dialog_id_exists() function. >>>> >>>> Andreas >>>> >>>>> On 28.11.2018, at 12:51, Daniel-Constantin Mierla <[email protected]> >>>>> wrote: >>>>> >>>>> Hello, >>>>> >>>>> can you try with the patch from next commit: >>>>> >>>>> - >>>>> https://github.com/kamailio/kamailio/commit/55c7f781be7cc40d0cd161640a47244aad60c0e7 >>>>> >>>>> Cheers, >>>>> Daniel >>>>> >>>>> On 28.11.18 12:34, Andreas Granig wrote: >>>>>> Hi Daniel, >>>>>> >>>>>> I started fresh (never tried this module before), but after googling for >>>>>> the error, I came across Juha’s post, which sounds quite familiar. >>>>>> >>>>>> So I’m having a phone subscribing to message-summary of >>>>>> [email protected], and I have a script sending a PUBLISH in behalf of >>>>>> [email protected]. This PUBLISH goes right into handle_publish in my >>>>>> config (with presence_mwi loaded), so nothing really special here, I >>>>>> believe. >>>>>> >>>>>> Andreas >>>>>> >>>>>>> On 28.11.2018, at 12:23, Daniel-Constantin Mierla <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> some clarifications in order to see where to look: you just started to >>>>>>> play fresh with it and get this error? Or an old configuration that used >>>>>>> to work in the past is now throwing the error? >>>>>>> >>>>>>> Cheers, >>>>>>> Daniel >>>>>>> >>>>>>> On 28.11.18 12:13, Andreas Granig wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Currently playing with presence_mwi in kamailio 5.1, and it appears >>>>>>>> the issue reported by Juha two years ago at >>>>>>>> https://lists.kamailio.org//pipermail/sr-dev/2016-September/036609.html >>>>>>>> seems to have appeared again somewhere along the way. >>>>>>>> >>>>>>>> I’m sending a PUBLISH with message-summary event type, however I’m >>>>>>>> getting this error: >>>>>>>> >>>>>>>> ERROR: presence [presentity.c:283]: check_if_dialog(): failed to parse >>>>>>>> xml document >>>>>>>> >>>>>>>> As said in the old thread, it’s not an XML document, so it shouldn’t >>>>>>>> try to treat it as such. Any ideas? >>>>>>>> >>>>>>>> Best, >>>>>>>> Andreas >>>>>>>> _______________________________________________ >>>>>>>> Kamailio (SER) - Users Mailing List >>>>>>>> [email protected] >>>>>>>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users >>>>>>> -- >>>>>>> Daniel-Constantin Mierla -- www.asipto.com >>>>>>> www.twitter.com/miconda -- www.linkedin.com/in/miconda >>>>>>> Kamailio World Conference -- www.kamailioworld.com >>>>>>> Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com >>>>>>> >>>>> -- >>>>> Daniel-Constantin Mierla -- www.asipto.com >>>>> www.twitter.com/miconda -- www.linkedin.com/in/miconda >>>>> Kamailio World Conference -- www.kamailioworld.com >>>>> Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com >>>>> >>> -- >>> Daniel-Constantin Mierla -- www.asipto.com >>> www.twitter.com/miconda -- www.linkedin.com/in/miconda >>> Kamailio World Conference -- www.kamailioworld.com >>> Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference -- www.kamailioworld.com Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com _______________________________________________ Kamailio (SER) - Users Mailing List [email protected] https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
