Hello, I haven't authored that patch and also never needed an underscore in host part of the URI, but also it didn't affect me before that change. I guess Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine to add some parameter to control that. Cheers, Daniel On 28.08.19 15:34, [email protected] wrote: > > Hello, > > > > Hmm, ok. Saw it. > > Is it possible to reconsider a less strict control? > > > > Regards, > > > > Igor. > > > > *De :*Daniel-Constantin Mierla <[email protected]> > *Envoyé :* mercredi 28 août 2019 10:25 > *À :* [email protected]; 'Kamailio (SER) - Users Mailing > List' <[email protected]> > *Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2 > > > > Hello, > > reading again I see that the error with the host uri is printed from > the C code. I thought of another issue that was reported related to > IPv6 addresses in the URI that kamctl rejected. > > The problem is that the underscore is not allowed in hostname: the > relevant standard is RFC 1123, section 2.1 "Host Names and Numbers" > which limits host names to letters-digits-hyphen. > > I checked the commits log and it seems this more strict verification > was added by next commit: > > commit 4994960324d5353222b3de08515bed07802ab7bc > Author: Juha Heinanen <[email protected]> <mailto:[email protected]> > Date: Wed Jan 10 08:39:48 2018 +0200 > > core/parser: more strict parsing of sip uri host > > Regarding the $ALL_METHODS not being defined, iirc, you should set it > to . (or maybe -1 in this case). > > Cheers, > Daniel > > On 28.08.19 10:12, [email protected] > <mailto:[email protected]> wrote: > > Hello Daniel, > > > > We moved to the latest 5.2.4 but hostname with underscore are > still not handle properly. > > Is it a real design choice or a mistake somewhere in the code that > handle domain name? > > > > Regards, > > > > Igor. > > > > *De :*[email protected] > <mailto:[email protected]> <[email protected]> > <mailto:[email protected]> > *Envoyé :* mardi 27 août 2019 11:53 > *À :* [email protected] <mailto:[email protected]>; 'Kamailio > (SER) - Users Mailing List' <[email protected]> > <mailto:[email protected]> > *Objet :* RE: [SR-Users] lookup(aliases) issues with 5.2 > > > > Hello Daniel, > > > > Thank you for getting back to me. > > We will update with 5.2.4 and I'll let you know if it's solved. > > > > Regards, > > > > Igor. > > > > *De :*Daniel-Constantin Mierla <[email protected] > <mailto:[email protected]>> > *Envoyé :* mardi 27 août 2019 09:39 > *À :* Kamailio (SER) - Users Mailing List > <[email protected] > <mailto:[email protected]>>; [email protected] > <mailto:[email protected]> > *Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2 > > > > Hello, > > On 27.08.19 09:27, [email protected] > <mailto:[email protected]> wrote: > > Hello! > > > > Any help on that matter? Sounds like the domain parsing have > been updated. Is it possible to back on the previous mode? > > did you mean backporting to older branches? If yes, it was done to > branch 5.2, have you tried with latest version in that branch? > > Cheers, > Daniel > > > > Regards, > > > > Igor. > > > > *De :*[email protected] > <mailto:[email protected]> > <[email protected]> <mailto:[email protected]> > *Envoyé :* vendredi 23 août 2019 18:53 > *À :* 'Kamailio (SER) - Users Mailing List' > <[email protected]> <mailto:[email protected]> > *Objet :* lookup(aliases) issues with 5.2 > > > > Hello! > > > > I have notice some issues with lookup(aliases) since I > upgraded to 5.2 from 5.1: > > First with kamctl: If this default command is executed: > > > > ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN" "$2" \ > > "$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS" "$BR_FLAGS" > "$ALL_METHODS" > > > > as $ALL_METHODS is not defined, there is a huge value in > methods and then lookup(aliases) fails with -2. > > > > I have to update kamctl script and put -1 ("-1") instead of > the variable. So, now, methods is a NULL value in DB and my > alias is not ignored. But I use to make my alias like this: > sip:number@blabla_1.local > > Which is no longer works: ERROR: registrar [common.c:62]: > extract_aor(): failed to parse AoR [sip:number@blabla_1.local] > > > > Any idea of the difference since 5.2 with this behaviour? > Without the underscore, the AoR seems to be valid but I need > to support underscore as before. > > > > Regards, > > > > Igor. > > > > _______________________________________________ > > Kamailio (SER) - Users Mailing List > > [email protected] <mailto:[email protected]> > > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users > > -- > > Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com> > > www.twitter.com/miconda <http://www.twitter.com/miconda> -- > www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda> > > -- > Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com> > www.twitter.com/miconda <http://www.twitter.com/miconda> -- > www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda> -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda
_______________________________________________ Kamailio (SER) - Users Mailing List [email protected] https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
