Hi Daniel. Thank you for back porting the acc and dialog changes to 5.6 -- I continue to test, but can report that the updates on the 5.6 branch through bfc5c2aacb272e91da80096ef27fbe6fcfe9a746 are working properly for acc/dialog- based CDR generation. -A
On Monday, September 26, 2022 6:30:04 AM CDT Daniel-Constantin Mierla wrote: > Hello, > > as I am not a user of dialog variables, I am turning to community to ask > for help testing the current master branch with configurations that make > use of dialog variables and acc dialog-based cdr generation. > > With a few reports of issues related to dialog modules and unexpected > crashes, I looked over the code and noticed that the access of the value > for dialog variables was not protected, making them vulnerable of > invalid memory access in case of the variable was updated by another > process or dialog was terminated. > > I introduced a couple of new functions to try to cover different use > cases of getting the dlg variable values, dialog management code was not > affected, but given that these commits need to be backported to stable > branch (5.6), I want to get proper feedback from community that things > work fine. > > A previous attempt of a simpler fix was not enough, having side effects > to acc module for dialog-based cdr generation, because it was keeping > referenced to many dlg variables at the same time. > > In short, it would be appreciated any feedback on testing dialog and acc > with dialog-based cdr generation using git master branch. > > Cheers, > Daniel __________________________________________________________ Kamailio - Users Mailing List - Non Commercial Discussions * [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender! Edit mailing list options or unsubscribe: * https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
