Hello,
Yes, its aparently missing in the output. I checked in my local
checkout, its there.
But the version rc0 was set later as the commits in question, so they
should be included.
If the error is still there, re-open the ticket 3090 and add more
information there.
Cheers,
Henning
*From:* George Diamantopoulos <[email protected]>
*Sent:* Tuesday, May 10, 2022 8:06 PM
*To:* Henning Westerholt <[email protected]>
*Cc:* Kamailio (SER) - Users Mailing List <[email protected]>
*Subject:* Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK
Hello Henning,
Thanks for the reply. Here's the output, but I don't see anything
relevant to git commits:
version: kamailio 5.6.0-rc0 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS,
DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC,
Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,
FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR,
USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE
1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 10.2.1
BR,
George
On Tue, 10 May 2022 at 18:55, Henning Westerholt <[email protected]> wrote:
Hello,
it seems to be included, at least in the git branch.
~/repositories/5.6$ git log | egrep "c309122|ceb688b" -A 5
commit c309122864eaa2bfa58253290bed49084ccc9302
Author: Daniel-Constantin Mierla [email protected]
Date: Thu Apr 21 14:28:26 2022 +0200
topos: restore attributes based on direction for early dialog
requests
--
commit ceb688b3d364bb7b8d9f52b7238d560cb4e30b3d
Author: Daniel-Constantin Mierla [email protected]
Date: Thu Apr 21 09:00:09 2022 +0200
topos: use direction for loading invite record for other
early dialog requests
It would be good to double-check with the output of “kamailio
-v”, please paste it here.
Cheers,
Henning
*From:*George Diamantopoulos <[email protected]>
*Sent:* Tuesday, May 10, 2022 4:43 PM
*To:* Henning Westerholt <[email protected]>
*Cc:* Kamailio (SER) - Users Mailing List
<[email protected]>
*Subject:* Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK
Hello again,
I've just tested 5.6.0~rc0+bpo11.20220506004754.1 from
56-nightly, but loose_route() still returns false for
early-dialog UPDATE... Does this build include c309122 and
ceb688b referenced in
https://github.com/kamailio/kamailio/issues/3090?
Cheers,
George
On Thu, 7 Apr 2022 at 10:21, George Diamantopoulos
<[email protected]> wrote:
Hello all,
Thanks for the feedback, Henning. There seems to have already
been a ticket about this but it's closed now:
https://github.com/kamailio/kamailio/issues/2659
I'm a little confused here. It seems early-dialog UPDATE
should be handled similarly to PRACK, so I guess maybe a
patch like
https://github.com/kamailio/kamailio/commit/37830f53b1f21fba5beef5d8e22913c431dcd708
would be needed.
However, Daniel has commented in this issue about the need to
do record_route() in config. To quote him: "The module
requires record routing, so if the UPDATE requires to
re-enforce Record-Route, then you have to do it. [...] I was
aware that only NOTIFY requires to re-enforce Record-Route,
but can be also a matter of UA implementation to want it for
other requests."
However, RR reinforcement for NOTIFY only happens (in the
kamailio sample configuration file) in route[WITHINDLG] only
if loose_route() check is successful. In my case, UPDATEs
fail this test, so control goes directly to
"sl_send_reply("404","Not here");", same as the author of the
aforementioned ticket. Unless Daniel meant one needs to
reinforce RR for PRACKs in order for subsequent UPDATEs to work?
Any thoughts?
BR,
George
On Wed, 6 Apr 2022 at 22:48, Henning Westerholt
<[email protected]> wrote:
Hello,
Thanks for the update. Opening a github issue about it is
probably a good idea.
Cheers,
Henning
--
Henning Westerholt – https://skalatan.de/blog/
<https://skalatan.de/blog/>
Kamailio services – https://gilawa.com <https://gilawa.com/>
*From:* sr-users <[email protected]>
*On Behalf Of *George Diamantopoulos
*Sent:* Wednesday, April 6, 2022 7:29 PM
*To:* Kamailio (SER) - Users Mailing List
<[email protected]>
*Subject:* Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK
This seems to be a topos issue regardless of backend, I
tried with mariadb as storage and UPDATE routing fails in
the same way as it does with redis. I'll probably open an
issue on Github about this (early dialog UPDATE broken by
topos). PRACK seems to work fine in my case. Direction of
UPDATE vs PRACK however is different, not sure if that's
important in any way.
BR,
George
On Wed, 6 Apr 2022 at 06:31, George Diamantopoulos
<[email protected]> wrote:
Hello again,
I have confirmed the problem doesn't manifest without
loading the topos module. I'll see if I can also try
a different topos backend this week to confirm if
this is a topos_redis issue or topos in general.
BR,
George
On Tue, 22 Mar 2022 at 17:11, George Diamantopoulos
<[email protected]> wrote:
Hello Henning,
This is on kamailio 5.5.4.
I'll try with a different backend and without
topos and post the result here as soon as I find
the time, just curious if anyone has stumbled on
this with topos_redis before. Thanks!
BR,
George
On Tue, 22 Mar 2022 at 15:51, Henning Westerholt
<[email protected]> wrote:
Hello,
please give a recent 5.5.x Kamailio a try.
There was a fix regarding early-dialog UPDATE
handling in topos committed one year ago.
Cheers,
Henning
--
Henning Westerholt –
https://skalatan.de/blog/
<https://skalatan.de/blog/>
Kamailio services – https://gilawa.com
<https://gilawa.com/>
*From:* sr-users
<[email protected]> *On
Behalf Of *George Diamantopoulos
*Sent:* Monday, March 21, 2022 11:53 PM
*To:* [email protected]; Kamailio (SER) -
Users Mailing List <[email protected]>
*Subject:* Re: [SR-Users] TOPOS (5.1.[23])
breaks PRACK
Hello all,
Any chance this could be affecting
early-dialog UPDATE methods as well? I
haven't tried with a different backend
(mysql) yet, but loose_route returns false...
BR,
George
On Fri, 25 May 2018 at 18:00, Daniel Tryba
<[email protected]> wrote:
On Wed, May 23, 2018 at 10:51:37PM +0200,
Daniel-Constantin Mierla wrote:
> I got a bit of time to look at this
issue, can you try with the patch
> from the next commit?
>
> ?? -
>
https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129
>
This off by 1 fix solved the PRACK issue
with redis backend.
_______________________________________________
Kamailio (SER) - Users Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
__________________________________________________________
Kamailio - Users Mailing List - Non Commercial Discussions
*[email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
Edit mailing list options or unsubscribe:
*https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
