-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/04/2009 11:18 AM, Dmitri Pal wrote: > Dmitri Pal wrote: >> Dmitri Pal wrote: >> >>> See patch subject and commit comment. >>> This patch requires previous two patches I sent. >>> >>> >>> >> Self nack. >> I woke up today with a slightly better function names in mind. >> The updated patch will be out shortly. >> >> > New patch is attached. > >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> sssd-devel mailing list >>> sssd-devel@lists.fedorahosted.org >>> https://fedorahosted.org/mailman/listinfo/sssd-devel >>> >> >> >> > > > > ------------------------------------------------------------------------ > > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/sssd-devel
Nack: elapi_async_ctx should be opaque (not specified in the elapi_async.h). Your elapi_create_asctx() should allocate the memory for it and elapi_destroy_asctx() should deallocate memory for it. Similarly, elapi_check_asctx() should be an internal helper for elapi_create_asctx(), not a public function. In struct elapi_dispatcher: You don't need async_mode. It is sufficient to check whether async_ctx is non-NULL. Also note that you removed the line that sets handle->async_mode = 1, so if you're relying on that, it's broken anyway. What is the point of "offset" in struct elapi_dispatcher and elapi_event_ctx? - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhOPgACgkQeiVVYja6o6MjzgCglS6gA2Rr3IgOat46GUSQX8Ke +hwAoK0jew0q1I2i21QfYek16H/ygdiE =qbVy -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
