On Tue, Sep 15, 2009 at 05:49:49PM -0400, Simo Sorce wrote:
> This patch "should" fix a bug seen today in the wild concerning the
> proxy provider.
> I say should because I was not able to reproduce the bug in the first
> place, but from the debug I've seen this should fix it.
>
> Simo.
ACK for 1/2
.....
>
> + if (debug_level >= 7) {
> + if (!state->grp->gr_mem || !state->grp->gr_mem[0]) {
> + DEBUG(7, ("Group %s has no members!\n",
> + state->grp->gr_name));
> + } else {
> + int i = 0;
> + while (state->grp->gr_mem[i]) {
> + /* count */
> + i++;
> + }
> + DEBUG(7, ("Group %s has %d members!\n",
> + state->grp->gr_name, i));
> + }
> + }
Please make it a macro or a subroutine instead of adding it three times.
> +
> + if (state->grp->gr_mem && state->grp->gr_mem[0]) {
> + members = (const char **)state->grp->gr_mem;
> + } else {
> + members = NULL;
> + }
> +
> subreq = sysdb_store_group_send(state, state->ev, state->handle,
> state->domain,
> state->grp->gr_name,
> state->grp->gr_gid,
> - (const char **)state->grp->gr_mem,
> - NULL, NULL);
> + members, NULL, NULL);
wouldn't it be better to move the check into sysdb_store_group_send ?
bye,
Sumit
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
