On Thu, 2009-09-17 at 19:21 +0200, Jakub Hrozek wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 09/17/2009 06:08 AM, Dmitri Pal wrote: > > Dmitri Pal wrote: > >> > See patch comments for details. > >> > All three are not massive. > >> > 1) Comparison and sorting collections > The swapped != is certainly a bug: > if ((res =! 0) && (out_flags == 0)) { > if ((res =! 0) && (out_flags == 0)) {
I would advise against unneeded parentheses like in this case. If you wouldn't use them the compiler would warn you. Martin _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel