On 03/08/2010 02:45 PM, Sumit Bose wrote: > On Mon, Mar 08, 2010 at 04:29:12AM +0100, Martin Nagy wrote: >> On 03/05/2010 08:19 PM, Sumit Bose wrote: >>> On Fri, Mar 05, 2010 at 12:00:41PM -0500, Dmitri Pal wrote: >>>> Sumit Bose wrote: >>>>> Hi, >>>>> >>>>> the following two patches are related to the Kerberos locator plugin. >>>>> >>>>> The first patch removes the name resolution from the locator plugin and >>>>> let it use the IP address found by the resolver code. This way we can be >>>>> sure to always talk to the same server until the resolver chooses a new >>>>> server. >>>>> >>>>> The second patch tries to make debugging of the locator plugin easier by >>>>> activating it automatically if the debug level of the Kerberos provider >>>>> is 5 or higher. Also the timestamp and debug-to-files flags are >>>>> respected. >>>>> >>>>> bye, >>>>> Sumit >>>>> >>>> I had a very quick glance. >>>> I think you are missing checks after strdup(). >>>> >>>> ctx->kdc_addr = strdup((char *) buf); >>>> >>>> >>>> I am not familiar with the code so it is hard for me to comment on >>>> anything else. >>>> >>> >>> oops, new version attached. >> >> Hi, I can't apply the patch, can you please rebase? >> >> Thanks >> Martin > > sorry, this patch depends on 'Add expandable sequences to > krb5_ccachedir', but > > NACK to 0002, if at all debug-to-files needs to be handled differently.
ACK to 0001. Martin _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
