-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/03/2010 04:31 PM, Jan Zeleny wrote:
> Stephen Gallagher <sgall...@redhat.com> wrote:
>> if (be_is_offline(state->be_ctx)) {
>> /* Ok, we're offline. Return from the cache */
>> - ret = sdap_access_decide_offline(req);
>> + sdap_access_decide_offline(req);
>> goto finished;
>> }
>> Please add ret = EOK before 'goto finished'. While it just happens to be
>> true right now, I'd rather we kept this explicit here, in case we ever
>> add something above this that changes ret.
>
> That would create dead assignment and this patch should eliminate them rather
> than create new ones. I would agree with you if the ret value was used after
> "finished" label, but this isn't the case. I just want to be sure about this.
You are correct. I misread the "finished" label.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkyGJEYACgkQeiVVYja6o6ML/wCgps9OrVrKgsCWCMZy/n2Bg3HP
2psAnA71ZmEf7Ev4iqJkAp9YwpWTwdtR
=3+km
-----END PGP SIGNATURE-----
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
