Stephen Gallagher wrote: > On 09/16/2010 05:05 PM, Stephen Gallagher wrote: > > I've rewritten these patches. Now, instead of searching for individual > > netgroup entries, the code will take advantage of the memberOf plugin to > > return all netgroup triples in a single call to sysdb_getnetgr() > > > This approach will make life easier with LDAP as well, as we will have > > built-in loop prevention. > > > Please review these patches while my netgroup work is ongoing. > > > Patch 0001: New sysdb interfaces for netgroups. Add and delete support > > for netgroups entries, tuples and nested netgroups. > > > Patch 0002: Unit tests for the above interfaces. > > > > Yet another change to these patches. > > I realized that I actually need to get back the three strings from the > triple instead of the internal representation. It makes the most sense > for this to be done in sysdb_getnetgr(), so attached are two new patches > which changes the interface (again) to return a structure of three > strings instead of a single string representing the tuple. > > Stephen, I just glanced over. Did not have a thorough review. There is a bug in sysdb_netgr_split_triple The user, host and domain strings need to be initialized to NULL.
Have not looked at other places :) ------------------------- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
