On Thu, Sep 23, 2010 at 01:03:39PM +0200, Sumit Bose wrote:
> Hi,
>
> I've found two minor issues in ding-libs which are fixed by the attacked
> patches.
>
> bye,
> Sumit
Sorry, the first patch was incomplete, new version attached.
bye,
Sumit
From 9ee67d2ed2f9600591de3c76d0509c9a4a19d64f Mon Sep 17 00:00:00 2001
From: Sumit Bose <sb...@redhat.com>
Date: Thu, 23 Sep 2010 12:47:30 +0200
Subject: [PATCH 1/2] Fix typo in spec file
---
contrib/ding-libs.spec.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/ding-libs.spec.in b/contrib/ding-libs.spec.in
index 32e191e..d8fb183 100644
--- a/contrib/ding-libs.spec.in
+++ b/contrib/ding-libs.spec.in
@@ -12,7 +12,7 @@ BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
%global dhash_version 0.4.1
%global collection_version 0.6.0
%global ref_array_version 0.1.1
-%global basicobjecs_vesion 0.1.0
+%global basicobjects_version 0.1.0
%global ini_config_version 0.6.1
### Patches ###
--
1.7.2.3
From a23e65184f4d66ca3412128a742cf2526aaa7365 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sb...@redhat.com>
Date: Thu, 23 Sep 2010 12:48:00 +0200
Subject: [PATCH 2/2] Fix overflow in ini_parse unit test
---
ini/ini_parse_ut.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/ini/ini_parse_ut.c b/ini/ini_parse_ut.c
index f55b3c2..01b7077 100644
--- a/ini/ini_parse_ut.c
+++ b/ini/ini_parse_ut.c
@@ -192,10 +192,9 @@ int main(int argc, char *argv[])
srcdir = getenv("srcdir");
if(!srcdir) {
- confdir = malloc(sizeof(char)*3);
- sprintf(confdir, "./ini");
+ confdir = strdup("./ini");
} else {
- confdir = malloc(strlen(srcdir)+4*sizeof(char));
+ confdir = malloc(strlen(srcdir)+5*sizeof(char));
sprintf(confdir, "%s/ini", srcdir);
}
--
1.7.2.3
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
